Skip to content

Naga add hardcoded keysets #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: 🦋 [Main] Naga Branch
merged 13 commits into from
Aug 28, 2025
Merged

Naga add hardcoded keysets #866

merged 13 commits into from
Aug 28, 2025

Conversation

@GTC6244
Copy link
Contributor

@GTC6244 GTC6244 commented Aug 20, 2025

Description

  1. Updates to the latest develop build of networkContext.json to catch keysets. Adds a hardcoded naga-keyset1 value, since this is the coding in lit-node right now.

  2. Adds a LICENCE file for the wasm package ( suppresses a warning! )

  3. Removes wasm-opt for the release build of the wasm package. Might be a local descrepency.

Type of change

  • [X ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

e2e tests are passing

@GTC6244 GTC6244 requested a review from Ansonhkg as a code owner August 20, 2025 17:24
@CLAassistant
Copy link

CLAassistant commented Aug 20, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Ansonhkg Ansonhkg changed the base branch from master to naga August 20, 2025 18:06
@Ansonhkg Ansonhkg added Blocked stalled due to external dependencies, unresolved issues, or waiting on input from other teams or con and removed Blocked stalled due to external dependencies, unresolved issues, or waiting on input from other teams or con labels Aug 21, 2025
@Ansonhkg
Copy link
Collaborator

Ansonhkg commented Aug 21, 2025 •
edited
Loading

This is blocked until naga-dev, naga-staging and naga-test are deployed, as we will hit the Missing or invalid parameters error for the mintNextAndAddAuthMethods ABI method when testing against the live networks

@Ansonhkg
Copy link
Collaborator

Linking this PR: https://github.com/LIT-Protocol/lit-assets/pull/2164

@DashKash54
Copy link
Collaborator

This PR has been tested locally but not against a live network

@Ansonhkg
Copy link
Collaborator

Ansonhkg commented Aug 28, 2025 •
edited
Loading

naga-dev is now up and ready to be tested against.

We will be using this branch to release a naga-dev beta instead of the naga main branch until all live networks are deployed with the keyset change.

Or, we could add an optional network-specific overrides to handle this kindda thing, but that's another topic.

@Ansonhkg Ansonhkg merged commit 1d5c53c into naga Aug 28, 2025
2 of 3 checks passed
@Ansonhkg Ansonhkg deleted the naga_add_hardcoded_keysets branch August 28, 2025 11:15
@Ansonhkg Ansonhkg restored the naga_add_hardcoded_keysets branch August 28, 2025 11:16
@Ansonhkg
Copy link
Collaborator

Ansonhkg commented Aug 28, 2025 •
edited
Loading

My apologies @GTC6244 @DashKash54

This PR was accidentally merged as the same time when I merged this pr #877 (to fix the types) to the naga main branch.

I will create a new branch and re-add the changes for this branch, will update here.

--- Updated here
#880

@Ansonhkg Ansonhkg mentioned this pull request Aug 28, 2025
Closed
@Ansonhkg Ansonhkg mentioned this pull request Sep 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ansonhkg Ansonhkg Awaiting requested review from Ansonhkg Ansonhkg is a code owner

Assignees

@GTC6244 GTC6244

Labels

Blocked stalled due to external dependencies, unresolved issues, or waiting on input from other teams or con Feature on hold for next deployment v8 | Naga

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GTC6244 @CLAassistant @Ansonhkg @DashKash54